Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-paradox-apidoc to 1.1.0 #1099

Closed
wants to merge 1 commit into from

Conversation

scala-steward-asf[bot]
Copy link
Contributor

@scala-steward-asf scala-steward-asf bot commented Feb 4, 2024

About this PR

πŸ“¦ Updates com.lightbend.paradox:sbt-paradox-apidoc from 0.10.1 to 1.1.0 ⚠

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lightbend.paradox", artifactId = "sbt-paradox-apidoc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lightbend.paradox", artifactId = "sbt-paradox-apidoc" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-major, commit-count:1

@raboof
Copy link
Member

raboof commented Feb 9, 2024

The error is java.lang.UnsupportedClassVersionError: org/parboiled/trees/GraphNode has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0 in sbt validatePullRequest.

We should probably run validatePullRequest with jdk11 as that's what we're using to build the releases as well (#1107)?

@mkurz
Copy link
Contributor

mkurz commented Feb 9, 2024

@raboof See conversation starting with #1061 (comment)

@pjfanning
Copy link
Contributor

We have a discussion at https://lists.apache.org/thread/ro3rz6s8mvj7j9dp39oszf7rnr6hn19d - I might take it to a vote. My preference is to upgrade and use java 11 for doc building in our CI builds.

@raboof
Copy link
Member

raboof commented Feb 9, 2024

Thanks for the references!

We release Pekko itself with Java 11 already, but indeed if we want to keep supporting development under Java 8, and be consistent with other Pekko projects still building with Java 8, it might make sense to keep building the Pekko docs with Java 8 as well.

@scala-steward-asf scala-steward-asf bot force-pushed the update/sbt-paradox-apidoc-1.1.0 branch 2 times, most recently from c47c00f to 3a2b100 Compare February 18, 2024 00:04
@scala-steward-asf scala-steward-asf bot force-pushed the update/sbt-paradox-apidoc-1.1.0 branch 2 times, most recently from 2f64643 to f897d57 Compare February 27, 2024 02:40
@scala-steward-asf scala-steward-asf bot force-pushed the update/sbt-paradox-apidoc-1.1.0 branch from f897d57 to a25f3ee Compare March 3, 2024 00:04
@mdedetrich
Copy link
Contributor

Ill be closing this PR as its no longer necessary, FYI of the paradox related dependencies are now centralized in pekko-sbt-paradox which is also solving all of the manual workarounds.

@mdedetrich mdedetrich closed this Mar 4, 2024
@mdedetrich mdedetrich deleted the update/sbt-paradox-apidoc-1.1.0 branch March 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants