You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's used in a lot of places internally but the most performance sensitive area is the pekko-stream code (eg Flow, Source, etc).
The obvious solution of using pekko.util.ccompat.JavaConverters to convert using .asScala.toSeq doesn't compile in Scala 2.12 because toSeq gives a scala.Seq instead of a scala.immutable.Seq.
We could use .asScala.toList but that is likely to be slower. We could also a new Util.immutableWrappingSeq function that has different implementations for Scala 2.12 (possibly delegate to existing immutableSeq) and Scala 2.13+ that uses .asScala.toSeq.
The text was updated successfully, but these errors were encountered:
pekko/actor/src/main/scala/org/apache/pekko/japi/JavaAPI.scala
Lines 269 to 281 in 22a7385
Follow up to #1250.
It's used in a lot of places internally but the most performance sensitive area is the pekko-stream code (eg Flow, Source, etc).
The obvious solution of using pekko.util.ccompat.JavaConverters to convert using
.asScala.toSeq
doesn't compile in Scala 2.12 because toSeq gives a scala.Seq instead of a scala.immutable.Seq.We could use
.asScala.toList
but that is likely to be slower. We could also a new Util.immutableWrappingSeq function that has different implementations for Scala 2.12 (possibly delegate to existing immutableSeq) and Scala 2.13+ that uses.asScala.toSeq
.The text was updated successfully, but these errors were encountered: