Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureTimeoutSupport#timeout support #1359

Open
He-Pin opened this issue Jun 11, 2024 · 4 comments
Open

Add FutureTimeoutSupport#timeout support #1359

He-Pin opened this issue Jun 11, 2024 · 4 comments
Milestone

Comments

@He-Pin
Copy link
Member

He-Pin commented Jun 11, 2024

Motivation:
Just like Java 's orTimeout method, which will cancel the future(if possible) and complete it with a timeout exception.

@He-Pin He-Pin added this to the 1.1.0-M2 milestone Jun 11, 2024
@raboof
Copy link
Member

raboof commented Jul 29, 2024

I like this feature idea, but do we have any particular reason to need it in 1.1.0? I think we can remove it from the milestone, it can be introduced either before or after 1.1.0.

@He-Pin
Copy link
Member Author

He-Pin commented Jul 29, 2024

I use something like this in an internal project, so I submitted it here to gather feedback too.

@He-Pin
Copy link
Member Author

He-Pin commented Jul 30, 2024

@raboof What do you think about it, I would like to finish it this weekend.

@raboof
Copy link
Member

raboof commented Jul 30, 2024

I like the feature idea!

@pjfanning pjfanning modified the milestones: 1.1.0, 1.1.1 Aug 23, 2024
@pjfanning pjfanning modified the milestones: 1.1.1, 1.1.2 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants