Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish pekko-grpc-scalaph-protoc-plugin for Scala 2.13 #327

Conversation

raboof
Copy link
Member

@raboof raboof commented Jun 12, 2024

And make the dependency tree leaner.

Fixes #325 (though the use case is still somewhat unclear)

And make the dependency tree leaner.

Fixes apache#325 (though the use case is still somewhat unclear)
Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning added this to the v1.1.0-M2 milestone Jun 13, 2024
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to update maven plugin too?

@raboof
Copy link
Member Author

raboof commented Jun 13, 2024

LGTM, do we need to update maven plugin too?

The maven-plugin is currently not scala-version-specific (https://repo1.maven.org/maven2/org/apache/pekko/pekko-grpc-maven-plugin/) so I don't think so? Do you have any particular concerns?

@raboof raboof merged commit d486106 into apache:main Jun 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Scala 2.13 support for pekko-grpc-scalapb-protoc-plugin
4 participants