Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slf4j-api to 2.0.12 #277

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Update slf4j-api to 2.0.12 #277

merged 1 commit into from
Apr 6, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.slf4j:slf4j-api from 1.7.36 to 2.0.12 ⚠

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-api" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.slf4j", artifactId = "slf4j-api" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

@github-actions github-actions bot added the update label Apr 6, 2024
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, even if Pekko core is still on 1.7.x on 1.0.2 (but will move to 2.x in 1.1.0): Pekko 1.0.x even already has tests that test it works with slf4j 2.x as well.

Not merging yet to give people who think we should stick with 1.7 for a while a chance to voice that opinion, though.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 5763091 into main Apr 6, 2024
20 checks passed
@pjfanning pjfanning deleted the update/slf4j-api-2.0.12 branch April 6, 2024 14:47
@pjfanning
Copy link
Contributor

we have been updating all the 1.1 code bases to use slf4j 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants