Add signing for release artifacts #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
mdedetrich
force-pushed
the
add-signing-for-release
branch
2 times, most recently
from
e6b3b78
to
afc0e3a
Compare
|
Ill work on this more tomorrow, seems like we are using such an old version of gradle that the way to setup signing is different. |
mdedetrich
force-pushed
the
add-signing-for-release
branch
from
afc0e3a
to
16d904e
Compare
mdedetrich
commented
Aug 8, 2023
| setRequired({ | ||
| isReleaseVersion && gradle.taskGraph.hasTask("publish") | ||
| }) | ||
| useGpgCmd() |
There was a problem hiding this comment.
Gradle will use JVM signing by default, useGpgCmd() is set because people such as myself have their signing key stored on a key device (i.e. YubiKey) which doesn't work with JVM signing.
Its also consistent with sbt-gpg (which also uses gpg).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I havent tried this out yet, mainly just used the instructions from https://docs.gradle.org/current/userguide/signing_plugin.html#sec:signing_publications but I suspect we will find out if the signing works when we get there.