Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup gradle plugin for publishing #142

Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Aug 7, 2023

References: #113

Only thing that is missing is signing (see https://github.com/gradle-nexus/publish-plugin#configure-signing) but lets do that separately.

tags = ['pekko', 'streams', 'reactive']
publishing {
publications.withType(MavenPublication) {
pom {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the pom details were outdated/missing. This data was retrieved by copying it from the pom of one of the sbt artifacts of this project

@mdedetrich mdedetrich force-pushed the setup-gradle-plugin-for-publishing branch from c4875d2 to 13ea579 Compare August 7, 2023 09:44
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure at all about hardcoding snapshot urls into the gradle publishing

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit ae1c5f1 into apache:main Aug 7, 2023
16 checks passed
@mdedetrich mdedetrich deleted the setup-gradle-plugin-for-publishing branch August 7, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants