Allow producing JDK8 bytecode on newer JDK's #101
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Feb 9, 2024
|
Thanks, completely forgot about this PR. Will check it out later |
mdedetrich
force-pushed
the
allow-producing-jdk8-bytecode-newer-jdks
branch
3 times, most recently
from
244571f
to
fde7819
Compare
mdedetrich
force-pushed
the
allow-producing-jdk8-bytecode-newer-jdks
branch
from
fde7819
to
e99c01a
Compare
raboof
reviewed
Aug 12, 2024
| @@ -79,6 +79,13 @@ object Common extends AutoPlugin { | |||
| "-Wconf:msg=unused import:silent", | |||
| "-Wconf:cat=feature:silent")), | |||
| Compile / console / scalacOptions ~= (_.filterNot(consoleDisabledOptions.contains)), | |||
| // restrict to 'compile' scope because otherwise it is also passed to | |||
| // javadoc and -target is not valid there. | |||
There was a problem hiding this comment.
Suggested change
| // javadoc and -target is not valid there. | |
| // javadoc and --release is not valid there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to verify this with jardiff