Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical sec… #14751

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

@github-actions github-actions bot added Area: Drivers Drivers issues Size: S The size of the change in this PR is small labels Nov 13, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 13, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a summary and links to related issues, it is missing crucial information.

Here's what's missing:

  • Summary: Lacks details on what functional part of the code the original commit changed and how this revert addresses the regressions. Simply stating "regressions are reported" is insufficient. It needs to explain the nature of the regressions.
  • Impact: Completely empty. Needs to be filled out for all sections. At a minimum, it should indicate if this revert affects users, the build process, hardware, documentation, security, or compatibility. Since it reverts a previous change, it likely impacts some of these.
  • Testing: Empty. Needs to include information on the build host and targets used for testing, as well as the actual test logs before and after the revert. The logs should demonstrate that the regressions are indeed fixed.

Without this information, it's difficult to assess the impact of the revert and ensure it doesn't introduce new issues. The PR author needs to provide these missing details before it can be properly reviewed and merged.

@yamt
Copy link
Contributor Author

yamt commented Nov 13, 2024

the ci failure looks unrelated

 CMake Error at /github/workspace/sources/nuttx/build/_deps/libmetal-subbuild/libmetal-populate-prefix/src/libmetal-populate-stamp/download-libmetal-populate.cmake:170 (message):
  Each download failed!

    error: downloading 'https://github.com/OpenAMP/libmetal/archive/a4bce3507502a7eb9e29bafe0eb174ed5c4316e9.zip' failed
          status_code: 28
          status_string: "Timeout was reached"
          log:
          --- LOG BEGIN ---
            Trying 140.82.114.4:443...

  Connection timed out after 30000 milliseconds

  Closing connection 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Drivers Drivers issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants