Update nb-javac to jdk-22.0.1 #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
do not merge
mbien
commented
May 7, 2024
mbien
force-pushed
the
nb-javac-2201
branch
2 times, most recently
from
9ce1e9c
to
b8bed75
Compare
mbien
commented
May 7, 2024
Comment on lines
21
to
22
| release.external/nb-javac-jdk-22+33-api.jar=modules/ext/nb-javac-jdk-22-33-api.jar | ||
| release.external/nb-javac-jdk-22+33.jar=modules/ext/nb-javac-jdk-22-33.jar | ||
| release.external/nb-javac-jdk-22.0.1+8-api.jar=modules/ext/nb-javac-jdk-22.0.1_8-api.jar | ||
| release.external/nb-javac-jdk-22.0.1+8.jar=modules/ext/nb-javac-jdk-22.0.1_8.jar |
There was a problem hiding this comment.
note for future me: JarClassLoader doesn't like the + likely due to url path encoding.
mbien
force-pushed
the
nb-javac-2201
branch
3 times, most recently
from
d81e535
to
278f222
Compare
|
used the dev-build from this PR and the test project @matthiasblaesing provided from #6826 (comment) and everything was working fine (opening the project in NB 21 would cause a CCE). |
This was referenced May 8, 2024
|
switched from staging to maven central |
mbien
removed
the
do not merge
jtulach
approved these changes
May 10, 2024
|
let's merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrades nb-javac from jdk-22+33 to jdk-22.0.1+8
currently uses a staged buildfixes #6826 due to https://bugs.openjdk.org/browse/JDK-8322159