Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nb-javac to jdk-21u (~build 35) #6425

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Sep 8, 2023

Update nb-javac to recent version.

@dbalek dbalek added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Sep 8, 2023
@dbalek dbalek added this to the NB20 milestone Sep 8, 2023
@dbalek dbalek self-assigned this Sep 8, 2023
@dbalek dbalek force-pushed the dbalek/nb-javac-update branch 2 times, most recently from 2c0dd51 to 8411ab2 Compare September 8, 2023 07:31
@dbalek dbalek added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Upgrade Library Library (Dependency) Upgrade labels Sep 8, 2023
@dbalek dbalek force-pushed the dbalek/nb-javac-update branch 2 times, most recently from 80b8e91 to 1b3ef36 Compare September 8, 2023 15:51
@dbalek dbalek requested a review from lahodaj September 12, 2023 12:45
@dbalek dbalek removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Sep 12, 2023
Comment on lines -17 to +18
2D8ACD8AAD9C74FDAAA9D7BBAF4278A57E2D86E0 com.dukescript.nbjavac:nb-javac:jdk-21+26:api
9A9BAB9DC8497962967345A59CDD8CBC9D73A40D com.dukescript.nbjavac:nb-javac:jdk-21+26
D5113DE0BE3E296D3D9F2139F0102FDD9EB0D993 com.dukescript.nbjavac:nb-javac:jdk-21u:api
A9C5BABB481C07742E0C4FCD150DB6E6DE2C2119 com.dukescript.nbjavac:nb-javac:jdk-21u
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference: since the artifact lost the build number, this is a build based on this hash openjdk/jdk21u@aef25fc which is a bit more recent than JDK 21+35.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dbalek dbalek merged commit b5a8baf into apache:master Sep 18, 2023
36 checks passed
@dbalek dbalek deleted the dbalek/nb-javac-update branch September 18, 2023 09:07
@mbien mbien changed the title Update nb-javac to jdk-21u. Update nb-javac to jdk-21u (~build 35) Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants