Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in annotation processor initialization #6422

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Handle errors in annotation processor initialization #6422

merged 1 commit into from
Sep 8, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Sep 7, 2023

If an annotation processor initialization crashes, just log the error and continue, rather than crash the whole processing.

@dbalek
If an annotation processor initialization crashes, just log the error…
c916ce6 
… and continue, rather than crash the whole processing.
@dbalek dbalek added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Sep 7, 2023
@dbalek dbalek added this to the NB20 milestone Sep 7, 2023
@dbalek dbalek self-assigned this Sep 7, 2023
@mbien
Copy link
Member

mbien commented Sep 8, 2023

this might help with #4853 and #4852

@dbalek dbalek merged commit 1867e0d into apache:master Sep 8, 2023
36 checks passed
@dbalek dbalek deleted the dbalek/apt-fix branch September 8, 2023 06:24
lahodaj
lahodaj approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note there is java/java.source.base/test/unit/src/org/netbeans/modules/java/source/indexing/CrashingAPTest.java, so it should be possible to create a test for this.

This was linked to issues Sep 8, 2023
Unexpected Exception reported during background scan of project #4852
Closed
Unexpected Exception reported during Clean and Build of Project #4853
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahodaj lahodaj lahodaj approved these changes

@sdedic sdedic sdedic approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

Assignees

@dbalek dbalek

Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB20
5 participants
@dbalek @mbien @MartinBalin @sdedic @lahodaj