LSP: Fixed problem with workspace/symbols called before first JavacCompiler created. #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
added
LSP
MartinBalin
approved these changes
Sep 7, 2023
|
I don't mind this patch, but I wonder if there would be opportunity to solve this in the infrastructure, e.g. by synthesizing some ClasspathInfo when none is provided for this task? |
It is hard to create any ClasspathInfo without a FileObject (before any project or file gets opened) |
sdedic
approved these changes
Sep 8, 2023
.../java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/WorkspaceServiceImpl.java
Outdated
Show resolved
Hide resolved
dbalek
force-pushed
the
dbalek/lsp-workspace-symbols-fix
branch
from
7379482
to
2f66050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was with
ParserManager.parseWhenScanFinished("text/x-java", new UserTask() {...called before the firstJavacParserwas created byjava.sourceinfrastructure. SinceJavacParsercannot be created without supplying aClasspathInfo, exception was thrown and the givenUserTaskwas not executed. Fixed by supplying theClasspathInfobased on the opened projects.