Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: In the navigator, inherited members are displayed in a different color, similar to how it is done in java #6393

Merged

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Aug 30, 2023

Example code:

Code example

<?php

trait Foo 
{
    public function foo(): void {} 
}


class ParentClass 
{
    public int $a;
    
    public function bar(): void {}
}

class ChildClass extends ParentClass
{
    use Foo;
    
    public int $b;
    
    public function fooBar(): void {}
}

before:
before before_dark

after:
after after_dark

@mbien mbien added the PHP [ci] enable extra PHP tests (php/php.editor) label Aug 30, 2023
@apache apache locked and limited conversation to collaborators Aug 30, 2023
@apache apache unlocked this conversation Aug 30, 2023
@mbien mbien requested review from junichi11 and tmysik August 30, 2023 18:53
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@junichi11
Copy link
Member

@troizet Please attach screenshots with a dark theme. Thanks!

@junichi11 junichi11 added this to the NB20 milestone Aug 31, 2023
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@junichi11 junichi11 merged commit 0322fce into apache:master Sep 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants