Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Barrier for Horovod KV Store API #21217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Barrier for Horovod KV Store API #21217

wants to merge 1 commit into from

Conversation

rbyche
Copy link

@rbyche rbyche commented Sep 7, 2023

Description

Added barrier function, which was missing from Horovod KV Store API.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Add _barrier function to kvstore.Horovod

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@rbyche rbyche requested a review from szha as a code owner September 7, 2023 08:17
@mxnet-bot
Copy link

Hey @rbyche , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, miscellaneous, unix-gpu, website, sanity, centos-gpu, windows-cpu, windows-gpu, unix-cpu, clang, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 7, 2023
@rbyche
Copy link
Author

rbyche commented Sep 9, 2023

@mxnet-bot run ci [centos-gpu, edge, miscellaneous, unix-gpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, website, unix-gpu, centos-gpu, edge]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants