Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tox dist install checks #1926

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix tox dist install checks #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae935f1
Fix dist install checks - add missing set -e.
Kami Aug 1, 2023
42426ea
For now, disable dist checks under Python 3.12.
Kami Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ jobs:
tox -e py${{ matrix.python_version }}

- name: Run dist install checks tox target
if: ${{ matrix.python_version != 'pypy-3.7' && matrix.python_version != 'pyjion' }}
# NOTE: 3.12 will be failing until we migrate away from setup.py
if: ${{ matrix.python_version != 'pypy-3.7' && matrix.python_version != 'pyjion' && matrix.python_version != '3.12-dev' }}
run: |
tox -e py${{ matrix.python_version }}-dist,py${{ matrix.python_version }}-dist-wheel

Expand Down
3 changes: 2 additions & 1 deletion scripts/dist_install_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
set -e

# Verify library installs without any dependencies when using python setup.py
# install
Expand All @@ -26,7 +27,7 @@ python --version
pip show requests && exit 1
pip show typing && exit 1
pip show enum34 && exit 1
pip show apache-libcloud
pip show apache-libcloud && exit 1

# Install the library
python setup.py install
Expand Down
3 changes: 2 additions & 1 deletion scripts/dist_wheel_install_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
# under the License.

# Verify library installs without any dependencies when using built wheel
set -e

echo "Running dist wheel install checks"
python --version
Expand All @@ -26,7 +27,7 @@ python --version
pip show requests && exit 1
pip show typing && exit 1
pip show enum34 && exit 1
pip show apache-libcloud
pip show apache-libcloud && exit 1
rm -rf dist/apache_libcloud-*.whl

pip install wheel
Expand Down