feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548

nathanlo99 · 2024-09-20T18:34:09Z

It would be nice to be able to spawn a read-only server on a snapshot of a given server.

This PR implements this feature, and introduces two new flags --use-checkpoint and --keep-checkpoint to manage the snapshot.

PragmaTwice · 2024-09-21T04:40:29Z

src/cli/main.cc

+std::optional<std::string> checkpoint_location = std::nullopt;
+bool keep_checkpoint = false;


We can move them to CLIOptions rather than global variables.

git-hulk · 2024-09-21T05:03:14Z

src/cli/main.cc

+      MakeScopeExit([&config, &old_checkpoint_dir] { config.checkpoint_dir = old_checkpoint_dir; });
+
+  engine::Storage storage(&config);
+  if (const auto s = storage.Open(kDBOpenModeForReadOnly); !s.IsOK()) {


Can return the error as a Status instead of an exception.

Add checkpoints

e8fd991

PragmaTwice reviewed Sep 21, 2024

View reviewed changes

git-hulk reviewed Sep 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548

feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548

nathanlo99 commented Sep 20, 2024

PragmaTwice Sep 21, 2024 •

edited

Loading

git-hulk Sep 21, 2024

		std::optional<std::string> checkpoint_location = std::nullopt;
		bool keep_checkpoint = false;

feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548

Are you sure you want to change the base?

feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548

Conversation

nathanlo99 commented Sep 20, 2024

PragmaTwice Sep 21, 2024 • edited Loading

Choose a reason for hiding this comment

git-hulk Sep 21, 2024

Choose a reason for hiding this comment

PragmaTwice Sep 21, 2024 •

edited

Loading