feat: Bitmap type DUMP/RESTORE command support #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poipoiPIO thanks for your contribution. |
git-hulk
reviewed
Sep 14, 2024
git-hulk
approved these changes
Sep 14, 2024
torwig
approved these changes
Sep 14, 2024
|
|
@poipoiPIO Thank you. |
Thank you for reviewing! |
mapleFU
reviewed
Sep 14, 2024
| redis::Bitmap bitmap_db(storage_, ns_); | ||
| Config *config = storage_->GetConfig(); | ||
| uint32_t max_btos_size = static_cast<uint32_t>(config->max_bitmap_to_string_mb) * MiB; | ||
| auto s = bitmap_db.GetString(ctx, key, max_btos_size, &value); |
There was a problem hiding this comment.
@git-hulk would this meet the same issue like lsb to msb?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes requested by #2518
Summary
This PR extends dump and restore operations to provide support for bitmap-type objects using existing string object serialisation and deserialisation routines.