Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Top-K data structure and commands #2424

Open
1 of 2 tasks
PragmaTwice opened this issue Jul 15, 2024 · 5 comments
Open
1 of 2 tasks

Support Top-K data structure and commands #2424

PragmaTwice opened this issue Jul 15, 2024 · 5 comments
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Redis Stack already supports this probabilistic data structure, and we can support it too.

https://redis.io/docs/latest/develop/data-types/probabilistic/top-k/
https://redis.io/docs/latest/commands/?group=topk

Solution

Please share your design proposal through issue/discussion before submitting a PR.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@PragmaTwice PragmaTwice added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Jul 15, 2024
@zweix123
Copy link

zweix123 commented Jul 20, 2024

I hope to complete this issue. Can you assign it to me.

@git-hulk
Copy link
Member

@zweix123 Assigned, thank you! Could you please propose the design before starting implementation? So that we can discuss the design in the early stage.

@zweix123
Copy link

@zweix123 Assigned, thank you! Could you please propose the design before starting implementation? So that we can discuss the design in the early stage.

Yes, I have such thoughts. Please give me some time, it won't be too long, about a day.

@git-hulk
Copy link
Member

@zweix123 Thank you! There's no rush, it's good to propose the design while you get time and are ready to review.

@zweix123
Copy link

A considerable amount of design has been completed, but there are some difficulties that will be discussed here: Kvrocks-Discussions-Difficulties in designing documents for Top-K data structures and commands #2449.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants