OAK-11100: remove use of Guava transform/filter #1723
Conversation
There was a problem hiding this comment.
Ok for oak-run-common and oak-run modules. I did not look at the other modules.
| @@ -234,7 +235,8 @@ private Map<ExternalIdentityRef, SyncEntry> collectSyncEntries(@NotNull Iterable | |||
| */ | |||
| private void collectSyncEntries(@NotNull Iterable<ExternalIdentityRef> declaredGroupRefs, long depth, @NotNull Map<ExternalIdentityRef, SyncEntry> map) throws ExternalIdentityException, RepositoryException { | |||
| boolean shortcut = shortcut(depth); | |||
| for (ExternalIdentityRef ref : Iterables.filter(declaredGroupRefs, this::isSameIDP)) { | |||
| Iterable<ExternalIdentityRef> filtered = () -> CollectionUtils.toStream(declaredGroupRefs).filter(this::isSameIDP).iterator(); | |||
There was a problem hiding this comment.
How about having a util for this transformation as well?
@NotNull
public static Iterable toIterable(@NotNull Iterable iterable, @NotNull Predicate<? super T> predicate) {
Objects.requireNonNull(iterable);
Objects.requireNonNull(predicate);
return () -> StreamSupport.stream(iterable.spliterator(), false).filter(predicate).iterator();
}
There was a problem hiding this comment.
Another option could be to use commons-collections IterableUtils.filteredIterable and same goes for Iterator.
There was a problem hiding this comment.
Using the first proposal wouldn't work well when mutiple stream manipulations are changed.
|
Could you please revert changes to |
No description provided.