Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[529] Build xtable with scala version(s) #544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rangareddy
Copy link
Contributor

Important Read

This pull request aims to address issues #529

What is the purpose of the pull request

To support building the xtable with multiple scala versions i.e 2.12 and 2.13.

Brief change log

  • Added scala12 and scala13 version properties in pom.xml file.
<scala12.version>2.12.15</scala12.version>
<scala13.version>2.13.8</scala13.version>
  • Added profiles to support scala12 and scala13
<!--Scala 2.12 Profile -->
<profile>
    <id>scala-2.12</id>
    <activation>
        <activeByDefault>true</activeByDefault>
    </activation>
    <properties>
        <scala.version>${scala12.version}</scala.version>
        <scala.version.prefix>2.12</scala.version.prefix>
    </properties>
    <build>
        <pluginManagement/>
    </build>
</profile>

<!--Scala 2.13 Profile -->
<!-- Once hudi supports scala 2.13 then enable following profile -->
<!--<profile>
    <id>scala-2.13</id>
    <activation>
        <activeByDefault>false</activeByDefault>
    </activation>
    <properties>
        <scala.version>${scala13.version}</scala.version>
        <scala.version.prefix>2.13</scala.version.prefix>
    </properties>
    <build>
        <pluginManagement>
            <plugins>
                <plugin>
                    <groupId>net.alchim31.maven</groupId>
                    <artifactId>scala-maven-plugin</artifactId>
                    <configuration>
                        <args>
                            <arg>-unchecked</arg>
                            <arg>-deprecation</arg>
                            <arg>-feature</arg>
                            <arg>-explaintypes</arg>
                            <arg>-target:jvm-1.8</arg>
                        </args>
                        <compilerPlugins/>
                    </configuration>
                </plugin>
            </plugins>
        </pluginManagement>
    </build>
</profile>-->

Verify this pull request

Run $ mvn clean install -DskipTests -U locally.

Note: Hudi does not yet support Scala 2.13 jars, so the scala-2.13 profile is commented out. Once Hudi supports Scala 2.13, we can use the following command to build xtable with Scala 2.13.

mvn clean install -DskipTests -Pscala-2.13 

References

@vinishjail97
Copy link
Contributor

Let's suffix the Scala version (2.12) to the jar name as suggested by @pjfanning
#529 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants