diff --git a/cpp/velox/substrait/SubstraitParser.cc b/cpp/velox/substrait/SubstraitParser.cc index b7e45b9f8b703..20353dee45152 100644 --- a/cpp/velox/substrait/SubstraitParser.cc +++ b/cpp/velox/substrait/SubstraitParser.cc @@ -298,7 +298,6 @@ std::unordered_map SubstraitParser::substraitVeloxFunc {"bit_and_merge", "bitwise_and_agg_merge"}, {"collect_set", "array_distinct"}, {"murmur3hash", "hash_with_seed"}, - {"make_decimal", "make_decimal_by_unscaled_value"}, {"modulus", "mod"} /*Presto functions.*/ }; diff --git a/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala b/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala index 627f3a4fa8546..1ab65d48e749d 100644 --- a/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala +++ b/gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala @@ -190,12 +190,8 @@ case class MakeDecimalTransformer( Seq(original.dataType, BooleanType), FunctionConfig.OPT)) - // use fake decimal literal, because velox function signature need to get return type - // scale and precision by input type variable - val toTypeNodes = - ExpressionBuilder.makeDecimalLiteral(new Decimal().set(0, original.precision, original.scale)) val expressionNodes = - Lists.newArrayList(childNode, toTypeNodes, new BooleanLiteralNode(original.nullOnOverflow)) + Lists.newArrayList(childNode, new BooleanLiteralNode(original.nullOnOverflow)) val typeNode = ConverterUtils.getTypeNode(original.dataType, original.nullable) ExpressionBuilder.makeScalarFunction(functionId, expressionNodes, typeNode) }