Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server refactoring #705

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Server refactoring #705

merged 8 commits into from
Jun 19, 2023

Conversation

bchapuis
Copy link
Member

No description provided.

@bchapuis bchapuis force-pushed the server-refactoring branch 2 times, most recently from 1cc5fa8 to 3217fd1 Compare June 17, 2023 12:33
this.sseBroadcaster = sse.newBroadcaster();
this.sseEventBuilder = sse.newEventBuilder();
var changeListener = new ChangeListener();
new Thread(changeListener).start();

Check warning

Code scanning / CodeQL

Start of thread in constructor

Class [ChangeResource](1) starts a thread in its constructor.
@bchapuis bchapuis force-pushed the server-refactoring branch 3 times, most recently from d5d5b51 to d228294 Compare June 18, 2023 22:39
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@bchapuis bchapuis marked this pull request as ready for review June 19, 2023 09:32
@bchapuis bchapuis merged commit 4ad3f58 into main Jun 19, 2023
@bchapuis bchapuis deleted the server-refactoring branch June 19, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant