IGNITE-22530 CDC: Add regex filters for cache names #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
NSAmelchev
reviewed
Sep 19, 2024
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerApplier.java
Show resolved
Hide resolved
NSAmelchev
reviewed
Sep 19, 2024
| /** | ||
| * @param includeTemplates Include regex templates | ||
| */ | ||
| public void setIncludeTemplates(Set<String> includeTemplates) { |
There was a problem hiding this comment.
Do we need a set of patterns and exclude patterns? Seems other products provide only single pattern, for example Kafka consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds multiple include and exclude filters to all current implementations of Apache Ignite CDC: Ignite2Ignite, Ignite2Kafka and additional filters for Kafka2Ignite. Filters implemented in form of pure regular expressions, and in case of invalid regexp CDC will throw PatternSyntaxException. Regexes can be added to the configurations of CDC streamers, and any cache created after it and matching the pattern, will be added "on-the-go".
More info in ticket: https://issues.apache.org/jira/browse/IGNITE-22530
This commit is a counterpart to commit with the same name in ignite, and they both should be merged simultaneously.