Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Catalog trait as python binding #604

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinjqliu
Copy link

@kevinjqliu kevinjqliu commented Sep 5, 2024

#538

hatch run dev:develop

@kevinjqliu
Copy link
Author

First time writing rust, most of this code is generated but helped me understand the codebase.
Here are a couple of things I've learned

Hi, @kevinjqliu I'm fine with adding it in pyiceberg_core module. But instead of adding sql catalog only, I think it's better to add a wrapper around Catalog trait? What do you think?

@liurenjie1024, following up on this comment #534 (comment)
Is the idea to expose only the Catalog trait to python? And perhaps a function to create different catalog implementations similar to what load_catalog is doing in python?

@liurenjie1024
Copy link
Collaborator

Is the idea to expose only the Catalog trait to python? And perhaps a function to create different catalog implementations similar to what load_catalog is doing in python?

@kevinjqliu Sorry for late reply. Yeah, this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants