Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove support of manifest list format as a list of file paths. #158

Closed
liurenjie1024 opened this issue Jan 9, 2024 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@liurenjie1024
Copy link
Collaborator

          Do you think it's a good idea to check this first so we don't need to write in enum pattern matching?

Originally posted by @Xuanwo in #129 (comment)

As we don't plan to support the manifest list as manifest list file, we will remove support for it.

@liurenjie1024 liurenjie1024 added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2024
@hiirrxnn
Copy link
Contributor

Could I work on this?

@liurenjie1024
Copy link
Collaborator Author

Could I work on this?

Sure, thanks for contributing! @hiirrxnn

@hiirrxnn
Copy link
Contributor

Which file/files should I make this change in ?

@liurenjie1024
Copy link
Collaborator Author

See this:

pub enum ManifestListLocation {

You can remove the enum, but it may requires modifying some places to get it compiled.

@Dysprosium0626
Copy link
Contributor

Dysprosium0626@e25adbb

Hi @liurenjie1024, here is my version of refactor. I just remove the enum and all the ManifestListLocation::ManifestFiles and change ManifestListLocation::ManifestListFile to String.

@liurenjie1024
Copy link
Collaborator Author

Hi, @Dysprosium0626 That looks great to me! Welcome to contribute.

@Dysprosium0626
Copy link
Contributor

Hi, you may close this issue now!
(BTW It looks like some of the issues like #192 could be close too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants