Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1979: Allow setting required properties for connecting to MySQL 8.4 and later. #1007

Conversation

jmuehlner
Copy link
Contributor

These properties allow connecting to a MySQL 8.4+ database server.

Either the public key can be retrieved from the server and set using the mysql-server-rsa-public-key-file property, or the public key can be automatically retrieved by setting the mysql-allow-public-key-retrieval property.

@jmuehlner jmuehlner force-pushed the GUACAMOLE-1979-provide-required-options-for-mysql-8.4 branch 2 times, most recently from 83e6fbe to 3ae6eaf Compare August 22, 2024 18:01
@necouchman
Copy link
Contributor

Changes look fine to me. Do older drivers and/or MySQL/MariaDB servers that don't support these properties react okay if/when they are set?

@jmuehlner jmuehlner force-pushed the GUACAMOLE-1979-provide-required-options-for-mysql-8.4 branch from 3ae6eaf to 7a66ec9 Compare August 22, 2024 23:31
@jmuehlner
Copy link
Contributor Author

jmuehlner commented Aug 23, 2024

Changes look fine to me. Do older drivers and/or MySQL/MariaDB servers that don't support these properties react okay if/when they are set?

Yep, confirmed that all of these new properties don't do anything when connecting to a database that doesn't support them. I tested with MySQL 5.3 and tried setting allowPublicKeyRetrieval to both "true" and "false", as well as setting serverRsaPublicKeyFile to both valid and invalid file paths, and I was able to connect as normal.

I also tried setting various invalid/unknown properties with both the MySQL and MariaDB drivers and they were simply ignored.

@necouchman
Copy link
Contributor

@jmuehlner One other question - this is currently targeted at the main branch - wasn't sure if the aim is to get this into the 1.6.0 release, or you're good with it waiting until the next one? Don't know if you're considering it a bug or not?

@jmuehlner
Copy link
Contributor Author

@jmuehlner One other question - this is currently targeted at the main branch - wasn't sure if the aim is to get this into the 1.6.0 release, or you're good with it waiting until the next one? Don't know if you're considering it a bug or not?

Yeah, I was thinking it might be better to avoid increasing the scope of 1.6.0 further. This isn't really a bug exactly - it's more of an improvement enabling the use of later MySQL versions.

@necouchman necouchman merged commit 30716c6 into apache:main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants