Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#177] feat(CI): Support publish Gravitino related jars and docs to OSSRH #543

Merged
merged 11 commits into from
Oct 25, 2023

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Oct 18, 2023

What changes were proposed in this pull request?

  • Add the Kotlin script in the root build.gradle.kts to publish Gravitino to maven central repo
  • Fix several Java doc issues.

Why are the changes needed?

Fix: #177

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Code Coverage Report

Overall Project 66.9% 🟢
Module Coverage
trino-connector 82.9% 🟢
core 74.24% 🟢
Files
Module File Coverage
trino-connector CatalogInjector.java 72.5% 🟢
core EntityKeyEncoder.java 100% 🟢
BinaryEntityKeyEncoder.java 99.47% 🟢
KvEntityStore.java 94.13% 🟢

@jerryshao
Copy link
Contributor

Let's wait for others to be merged first.

@yuqi1129 yuqi1129 self-assigned this Oct 18, 2023
.github/workflows/publish-gravitino.yml Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
.github/workflows/publish-gravitino.yml Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@jerryshao jerryshao changed the title [#177] improvement(pipeline): Support publish Gravitino related jars, docs and so on to OSSRH [#177] feat(CI): Support publish Gravitino related jars, docs and so on to OSSRH Oct 25, 2023
@jerryshao
Copy link
Contributor

@yuqi1129 the PR description is not accurate for now, please update it.

Overall LGTM, @xunliu please review again.

@yuqi1129
Copy link
Contributor Author

@yuqi1129 the PR description is not accurate for now, please update it.

Overall LGTM, @xunliu please review again.

I have updated the description of the PR.

@@ -42,6 +42,10 @@ java {
}
}

tasks.named("generateMetadataFileForMavenJavaPublication") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will the generateMetadataFileForMavenJavaPublication task be called? and this task name is too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of the publishing tasks. Please see below:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task name can be simplified, seems to long for now.

Copy link
Contributor Author

@yuqi1129 yuqi1129 Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename it as the following?

tasks.named("generateMetadataFileForMavenJavaPublication").configure {
    setName("newTaskName")
}

Personally, I do not see the need to change the default name for publishing tasks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean this name "generateMetadataFileForMavenJavaPublication" is predefined in the publish task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all tasks in the picture above were defined by the publishing plugin NOT me, I was even not aware this task before this changes.

@xunliu xunliu changed the title [#177] feat(CI): Support publish Gravitino related jars, docs and so on to OSSRH [#177] feat(CI): Support publish Gravitino related jars and docs to OSSRH Oct 25, 2023
@jerryshao jerryshao merged commit c7318af into apache:main Oct 25, 2023
2 checks passed
jerryshao pushed a commit that referenced this pull request Oct 26, 2023
…SSRH (#543)

### What changes were proposed in this pull request?

- Add the Kotlin script in the root `build.gradle.kts` to publish
Gravitino to maven central repo
- Fix several Java doc issues.

### Why are the changes needed?

Fix: #177 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Publish Graviton to mvn center repository
3 participants