[#516] feat(doc): add Iceberg REST service document #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
jerryshao
changed the title
yuqi1129
reviewed
Oct 19, 2023
jerryshao
reviewed
Oct 19, 2023
jerryshao
reviewed
Oct 19, 2023
jerryshao
reviewed
Oct 19, 2023
docs/iceberg-rest-service.md
Outdated
| | `gravitino.auxService.iceberg-rest.catalog-backend` | Catalog backend of Gravitino Iceberg REST server | `jdbc`| | ||
| | `gravitino.auxService.iceberg-rest.uri` | The jdbc connection address | `jdbc:postgresql://127.0.0.1:5432/`| | ||
| | `gravitino.auxService.iceberg-rest.warehouse ` | Warehouse directory of JdbcCatalog, you should set HDFS prefix explictly if using HDFS | `/user/hive/warehouse-jdbc/`| | ||
| | `gravitino.auxService.iceberg-rest.jdbc.user` | The username of the Jdbc connection| `jdbc username`| |
There was a problem hiding this comment.
Shall we align with gravitino iceberg catalog to use "jdbc-user" and "jdbc-password".
There was a problem hiding this comment.
I think we'd better not align with gravitino iceberg catalog. Gravitino configuration rule is somehow complex, introducing other rules like bypass, it's hard for Iceberg REST configuration to follow Gravitino configuration completely and will introduce complexity for Iceberg REST server users (maybe not Gravitino Iceberg REST catalog users.)
jerryshao
approved these changes
Oct 23, 2023
jerryshao
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add Iceberg REST service documnet
Why are the changes needed?
Fix: #516
Does this PR introduce any user-facing change?
No
How was this patch tested?
just document