[#462] fix(hive): validate non-null column type in Hive catalog #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
jerryshao
reviewed
Oct 13, 2023
...s/catalog-hive/src/main/java/com/datastrato/graviton/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
yuqi1129
reviewed
Oct 13, 2023
...s/catalog-hive/src/main/java/com/datastrato/graviton/catalog/hive/HiveCatalogOperations.java
Outdated
Show resolved
Hide resolved
jerryshao
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw an exception when encountering a non-nullable column type in Hive catalog
Why are the changes needed?
Currently, we only support Hive 2.x for Hive catalog, but 'NOT NULL' column constraint was supported since Hive3.0
Fix: #462
Does this PR introduce any user-facing change?
no
How was this patch tested?
UTs added