[#498] fix(test): Fix port conflict issue in UT #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Oct 12, 2023
server/src/test/java/com/datastrato/graviton/server/TestGravitonServer.java
Show resolved
Hide resolved
Code Coverage Report
|
yuqi1129
previously approved these changes
Oct 12, 2023
mchades
reviewed
Oct 12, 2023
| ENTRY_KV_ROCKSDB_BACKEND_PATH.getKey(), | ||
| ROCKS_DB_STORE_PATH, | ||
| GravitonServer.WEBSERVER_CONF_PREFIX + JettyServerConfig.WEBSERVER_HTTP_PORT.getKey(), | ||
| String.valueOf(RESTUtils.findAvailablePort(5000, 6000))), |
There was a problem hiding this comment.
I saw the same exception in com.datastrato.graviton.server.web.TestJettyServer, is it need to do the same process?
> Task :server-common:test
TestJettyServer > testStartAndStop() FAILED
java.lang.RuntimeException at TestJettyServer.java:48
Caused by: java.io.IOException at TestJettyServer.java:48
Caused by: java.net.BindException at TestJettyServer.java:48
jerryshao
changed the title
TestGravitonServer
mchades
approved these changes
Oct 12, 2023
Clearvive
pushed a commit
that referenced
this pull request
Oct 17, 2023
### What changes were proposed in this pull request? Change the `TestGravitonServer` to use random port instead of a default one to avoid port conflicts. ### Why are the changes needed? The port conflicts issue makes the test quite flaky, see #498 Fix: #498 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the
TestGravitonServerto use random port instead of a default one to avoid port conflicts.Why are the changes needed?
The port conflicts issue makes the test quite flaky, see #498
Fix: #498
Does this PR introduce any user-facing change?
Np.
How was this patch tested?
Existing UTs.