[#460][MINOR] docs: clarify deleteColumn doc #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
jerryshao
reviewed
Oct 12, 2023
| * | ||
| * @param fieldNames Field names of the column to delete. | ||
| * @param ifExists Silence the error if column doesn't exist during drop. | ||
| * @param ifExists If true, the change will succeed even if the field does not exist. |
There was a problem hiding this comment.
How about: "If true, silence the error if column doesn't exist during drop. Otherwise ..."
jerryshao
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the documentation in
deleteColumnto clarify the usage ofifExists.Why are the changes needed?
It's unclear how
ifExistsworksFix: #460
Does this PR introduce any user-facing change?
no
How was this patch tested?
UT added