[#4812] fix(core): Make ensure the schema exists before creating tables and topics #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g tables and topics (apache#4818) ### What changes were proposed in this pull request? If the schema is not created by Gravitino, the Gravitino will lack the metadata in the backend storage. If we create a table in this schema, the storage won't contain the metadata. So it will fail to set owner. Because the storage won't store the table. Because the storage won't contain schema id. This won't bring too much performance cost. Because loadSchema will use read lock after first loading. If we have cache, we could be more quick. ### Why are the changes needed? Fix: apache#4812 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added a ut.
jerryshao
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request? If the schema is not created by Gravitino, the Gravitino will lack the metadata in the backend storage.
If we create a table in this schema, the storage won't contain the metadata. So it will fail to set owner. Because the storage won't store the table. Because the storage won't contain schema id.
This won't bring too much performance cost. Because loadSchema will use read lock after first loading. If we have cache, we could be more quick.
Why are the changes needed?
Fix: #4812
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a ut.