[#390] improve(test): Consistency check in the graviton.conf file #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
yuqi1129
reviewed
Sep 18, 2023
| + File.separator | ||
| + "conf" | ||
| + File.separator | ||
| + "/graviton.conf.template"; |
There was a problem hiding this comment.
Good point, I removed the extra file separator.
jerryshao
reviewed
Sep 18, 2023
| for (Map.Entry<Object, Object> entry : properties.entrySet()) { | ||
| String propKey = (String) entry.getKey(); | ||
| Assertions.assertTrue( | ||
| configKeyMap.containsKey(propKey), |
There was a problem hiding this comment.
Here it looks like we will only check the configs that exist in the conf file, if not, the check logic will be passed, is that what we expected?
jerryshao
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ServerConfig.javaandConfigs.javafiles.Why are the changes needed?
Because property names in the
graviton.conf.templatefile need to be kept consistent withcom/datastrato/graviton/Configs.javaandcom/datastrato/graviton/server/ServerConfig.java,Otherwise, Graviton will not be able to read
graviton.conffile correctly.Fix: #390
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Added
ServerConfigTestin the test cases.