Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Make tag interface more proper #5000

Closed
jerqi opened this issue Sep 24, 2024 · 0 comments · Fixed by #5027
Closed

[Improvement] Make tag interface more proper #5000

jerqi opened this issue Sep 24, 2024 · 0 comments · Fixed by #5027
Assignees
@jerqi
Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything

Comments

@jerqi
Copy link
Collaborator

jerqi commented Sep 24, 2024 •
edited
Loading

What would you like to be improved?

image
If type name is duplicated with tag name, it will make users confusing.

How should we improve?

Use /api/metalakes/objects/{type}/{fullName}/tags/{tag} instead.
@jerqi jerqi added the improvement Improvements on everything label Sep 24, 2024
jerqi added a commit to qqqttt123/gravitino that referenced this issue Sep 26, 2024
@jerqi
[apache#5000] improvement(server): Move tag object API to object path
11de6b2
@jerqi jerqi mentioned this issue Sep 26, 2024
Merged
@jerqi jerqi self-assigned this Sep 26, 2024
@jerqi jerqi added 0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 labels Sep 26, 2024
jerqi added a commit to qqqttt123/gravitino that referenced this issue Sep 26, 2024
@jerqi
[apache#5000] improvement(server): Move tag object API to object path
ae0e2aa
jerqi added a commit to qqqttt123/gravitino that referenced this issue Sep 26, 2024
@jerqi
[apache#5000] improvement(server): Move tag object API to object path
6688b9f
@jerqi jerqi changed the title [Improvement] Make tag interface more property [Improvement] Make tag interface more proper Sep 26, 2024
github-actions bot pushed a commit that referenced this issue Sep 27, 2024
@jerqi @web-flow
[#5000] improvement(server): Move tag object API to object path (#5027)
da6cccd 
### What changes were proposed in this pull request?

Move tag related about metadata object API to object path

### Why are the changes needed?

Fix: #5000

### Does this PR introduce _any_ user-facing change?
Modified the document

### How was this patch tested?
Modified the UT.
@github-actions github-actions bot mentioned this issue Sep 27, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 27, 2024
@github-actions @jerqi
[#5000] improvement(server): Move tag object API to object path (#5028)
53c072d 
### What changes were proposed in this pull request?

Move tag related about metadata object API to object path

### Why are the changes needed?

Fix: #5000

### Does this PR introduce _any_ user-facing change?
Modified the document

### How was this patch tested?
Modified the UT.

Co-authored-by: roryqi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5000] improvement(server): Move tag object API to object path qqqttt123/gravitino
1 participant
@jerqi