Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] support custom APIs for Iceberg REST server #4959

Closed
FANNG1 opened this issue Sep 19, 2024 · 1 comment · Fixed by #4987
Closed

[Improvement] support custom APIs for Iceberg REST server #4959

FANNG1 opened this issue Sep 19, 2024 · 1 comment · Fixed by #4987
Assignees
@FANNG1
Labels
0.7.0 Release v0.7.0 ICEBERG-REST-SERVER improvement Improvements on everything

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Sep 19, 2024 •
edited
Loading

What would you like to be improved?

Supporting custom API extensions is crucial for the production enviroments.

How should we improve?

No response
@FANNG1 FANNG1 added the improvement Improvements on everything label Sep 19, 2024
@FANNG1
Copy link
Contributor Author

FANNG1 commented Sep 19, 2024

The initial idea is providing a configuration like gravitino.iceberg-rest.extensionPackages, and we could add custom packages and origin Iceberg REST packages to Jersey, like:

String extendedPackages =  xxx
ResourceConfig resourceConfig = new ResourceConfig();
resourceConfig.package(xxx,  "org.apache.gravitino.iceberg.service.rest")

@SinghAsDev WDYT?

@FANNG1 FANNG1 changed the title [Improvement] add a configuration to extend Iceberg REST server API [Improvement] support custom APIs for Iceberg REST server Sep 19, 2024
@FANNG1 FANNG1 mentioned this issue Sep 23, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 29, 2024
@FANNG1
[#4959] feat(Iceberg): support Iceberg REST extend API (#4987)
3c5d20f 
### What changes were proposed in this pull request?

support Iceberg REST extend API

### Why are the changes needed?

Fix: #4959 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
1. add new operation classes with new URI PATH to
`org.apache.gravitino.iceberg.service.rest2`
2. config `gravitino.iceberg-rest.extension-packages` to
`org.apache.gravitino.iceberg.service.rest2`
3. start Gravitino IcebergRESTServer
4. check new URI is accessable.
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FANNG1 FANNG1

Labels
0.7.0 Release v0.7.0 ICEBERG-REST-SERVER improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4959] feat(Iceberg): support Iceberg REST extend API FANNG1/gravitino
2 participants
@jerryshao @FANNG1