Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Change the Apache License comment style in client-python #4933

Closed
noidname01 opened this issue Sep 13, 2024 · 0 comments · Fixed by #4934
Closed

[Subtask] Change the Apache License comment style in client-python #4933

noidname01 opened this issue Sep 13, 2024 · 0 comments · Fixed by #4934
Assignees
@noidname01
Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue

Comments

@noidname01
Copy link
Collaborator

Describe the subtask

  • Current Apache License using docstring comment style, making Apache License appears in every generated document, which is not easy to read.

Parent issue

#4797
@noidname01 noidname01 added the subtask Subtasks of umbrella issue label Sep 13, 2024
@noidname01 noidname01 mentioned this issue Sep 13, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 14, 2024
@noidname01
[#4933] improvement(client-python): Change the Apache License comment…
4f961bb 
… style in client-python (#4934)

### What changes were proposed in this pull request?

* Change current Apache License comments in `client-python` from
docstrings into linewise comments
* Current Display
<img width="1261" alt="image"
src="https://github.com/user-attachments/assets/e641fa97-b654-4d32-9cdb-460667c00fe1">


### Why are the changes needed?

Fix: #4933

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew client:client-python:doc`

---------

Co-authored-by: TimWang <[email protected]>
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noidname01 noidname01

Labels
0.7.0 Release v0.7.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
2 participants
@jerryshao @noidname01