Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Name of Hive table properties' keys should follow project development specifications #490

Closed
mchades opened this issue Oct 11, 2023 · 0 comments · Fixed by #502
Closed

[Improvement] Name of Hive table properties' keys should follow project development specifications #490

mchades opened this issue Oct 11, 2023 · 0 comments · Fixed by #502
Assignees
@mchades
Labels
improvement Improvements on everything
Milestone
Graviton v0.2.0

Comments

@mchades
Copy link
Contributor

mchades commented Oct 11, 2023

What would you like to be improved?

As we discussed offline, the property key name should follow the unified standard, use a style with hyphens instead of camel case.

How should we improve?

‌‌Change the key name of the Hive table properties from hyphen style to camel case.
@mchades mchades added the improvement Improvements on everything label Oct 11, 2023
@mchades mchades self-assigned this Oct 11, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Oct 11, 2023
@mchades mchades mentioned this issue Oct 12, 2023
Merged
jerryshao pushed a commit that referenced this issue Oct 12, 2023
@mchades
[#490]refactor(hive): Hive table properties follow property name conv…
5355643 
…ention (#502)

### What changes were proposed in this pull request?
Rename some Hive table properties' name to follow the property name
convention

### Why are the changes needed?
Follow the unified standard for Graviton property

Fix: #490 

### Does this PR introduce _any_ user-facing change?
Yes, some names of Hive table properties changed

### How was this patch tested?
Existing UTs
Clearvive pushed a commit that referenced this issue Oct 17, 2023
@mchades
[#490]refactor(hive): Hive table properties follow property name conv…
78d627b 
…ention (#502)

### What changes were proposed in this pull request?
Rename some Hive table properties' name to follow the property name
convention

### Why are the changes needed?
Follow the unified standard for Graviton property

Fix: #490 

### Does this PR introduce _any_ user-facing change?
Yes, some names of Hive table properties changed

### How was this patch tested?
Existing UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.2.0
Development

Successfully merging a pull request may close this issue.

[#490]refactor(hive): Hive table properties follow property name convention mchades/graviton
2 participants
@jerryshao @mchades