Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add a framework to support multiple JDBC storage backend. #4832

Closed
yuqi1129 opened this issue Sep 2, 2024 · 0 comments · Fixed by #4833
Closed

[Improvement] Add a framework to support multiple JDBC storage backend. #4832

yuqi1129 opened this issue Sep 2, 2024 · 0 comments · Fixed by #4833
Assignees
@yuqi1129
Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Sep 2, 2024

What would you like to be improved?

Currently, we use hard code to support MySQL and H2 backend, all SQLs in mappers are constant, and it's hard to support other JDBC databases, so this PR is to add a framework so that Gravitino can use multiple JDBC database as backend.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Sep 2, 2024
@yuqi1129 yuqi1129 mentioned this issue Sep 2, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 5, 2024
@yuqi1129
[#4832] feat(core): Add basic framework to support multiple JDBC back…
e9929c8 
…end. (#4833)

### What changes were proposed in this pull request?

1. Add a framework to support multiple JDBC backend 
2. Modify all the mapper classes related to metalake, catalog, schema,
filesetset, table, topic and use new framework, others will use another
PR to avoid a large PR.

### Why are the changes needed?

To support more JDBC storage backend.

Fix: #4832 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing tests.
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Sep 5, 2024
This was referenced Sep 6, 2024
Closed
Merged
jerryshao pushed a commit that referenced this issue Sep 6, 2024
@yuqi1129
[#4868] improvement(core): Modify tag and user related mapper class t…
0403f31 
…o use the new framework to support multiple JDBC backend. (#4869)

### What changes were proposed in this pull request?

Change tag, user, and role-related code to support the new framework
introduced by #4832

### Why are the changes needed?

To support multiple JDBC backend.

Fix: #4868 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing UTs and ITs.
yuqi1129 added a commit to yuqi1129/gravitino that referenced this issue Sep 24, 2024
@yuqi1129
[apache#4832] feat(core): Add basic framework to support multiple JDB…
6222cf6 
…C backend. (apache#4833)

### What changes were proposed in this pull request?

1. Add a framework to support multiple JDBC backend 
2. Modify all the mapper classes related to metalake, catalog, schema,
filesetset, table, topic and use new framework, others will use another
PR to avoid a large PR.

### Why are the changes needed?

To support more JDBC storage backend.

Fix: apache#4832 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing tests.
@yuqi1129 yuqi1129 mentioned this issue Sep 24, 2024
Merged
jerqi pushed a commit to qqqttt123/gravitino that referenced this issue Sep 24, 2024
@yuqi1129 @jerqi
[apache#4868] improvement(core): Modify tag and user related mapper c…
4e4da09 
…lass to use the new framework to support multiple JDBC backend. (apache#4869)

### What changes were proposed in this pull request?

Change tag, user, and role-related code to support the new framework
introduced by apache#4832

### Why are the changes needed?

To support multiple JDBC backend.

Fix: apache#4868 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing UTs and ITs.
diqiu50 pushed a commit that referenced this issue Sep 24, 2024
@yuqi1129
[#4832] feat(core): Add basic framework to support multiple JDBC back…
bbf4773 
…end (#4998)

### What changes were proposed in this pull request?

1. Add a framework to support multiple JDBC backend 
2. Modify all the mapper classes related to metalake, catalog, schema,
filesetset, table, topic and use new framework, others will use another
PR to avoid a large PR.

### Why are the changes needed?

To support more JDBC storage backend.

Fix: #4832 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing tests.
@jerqi jerqi mentioned this issue Sep 24, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 24, 2024
@jerqi @yuqi1129
[#4868] improvement(core): Modify tag and user related mapper class t…
962da78 
…o use the new framework to support multiple JDBC backend. (#5001)

### What changes were proposed in this pull request?

Change tag, user, and role-related code to support the new framework
introduced by #4832

### Why are the changes needed?

To support multiple JDBC backend.

Fix: #4868 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

Existing UTs and ITs.

Co-authored-by: Qi Yu <[email protected]>
@jerryshao jerryshao added the 0.6.1 Release v0.6.1 label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4832] feat(core): Add basic framework to support multiple JDBC backend. yuqi1129/gravitino
2 participants
@jerryshao @yuqi1129