Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Exclude clients/client-python/.pytest_cache/ from rat test #2671

Closed
shaofengshi opened this issue Mar 25, 2024 · 0 comments · Fixed by #2672
Closed

[Subtask] Exclude clients/client-python/.pytest_cache/ from rat test #2671

shaofengshi opened this issue Mar 25, 2024 · 0 comments · Fixed by #2672
Assignees
@shaofengshi
Labels
subtask Subtasks of umbrella issue
Milestone
Gravitino 0.5.0

Comments

@shaofengshi
Copy link
Contributor

shaofengshi commented Mar 25, 2024 •
edited
Loading

Describe the subtask

I run gradle clean build under the project, but got RAT failed report, saying:

Unapproved Licenses:
/Users/shaofeng/Documents/workspace/gravitino/clients/client-python/.pytest_cache/CACHEDIR.TAG
/Users/shaofeng/Documents/workspace/gravitino/clients/client-python/.pytest_cache/README.md
/Users/shaofeng/Documents/workspace/gravitino/clients/client-python/.pytest_cache/v/cache/nodeids
/Users/shaofeng/Documents/workspace/gravitino/clients/client-python/.pytest_cache/v/cache/stepwise

I believe other guy will also get this error once they run "pytest" under the client-python module. So I think it should be excluded from rat test to improve the efficiency.

Parent issue

#2113
@shaofengshi shaofengshi added the subtask Subtasks of umbrella issue label Mar 25, 2024
@shaofengshi shaofengshi added this to the Gravitino 0.5.0 milestone Mar 25, 2024
@shaofengshi shaofengshi self-assigned this Mar 25, 2024
shaofengshi added a commit to shaofengshi/gravitino that referenced this issue Mar 25, 2024
@shaofengshi
apache#2671 exclude pytest_cache from rat test
8b4d098
@shaofengshi shaofengshi mentioned this issue Mar 25, 2024
Merged
jerryshao pushed a commit that referenced this issue Mar 25, 2024
@shaofengshi
[#2671] fix(python-client): exclude pytest_cache from rat test (#2672)
47a8da6 
### What changes were proposed in this pull request?

Exclude a hidden folder from gradle rat test.

### Why are the changes needed?

It will make the gradle build failed in local, once the user run pytest
for the python client.

Fix: #2671

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

After applying the patch, gradle build will success after running
pytest.
coolderli pushed a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
@shaofengshi
[apache#2671] fix(python-client): exclude pytest_cache from rat test (a…
18c8007 
…pache#2672)

### What changes were proposed in this pull request?

Exclude a hidden folder from gradle rat test.

### Why are the changes needed?

It will make the gradle build failed in local, once the user run pytest
for the python client.

Fix: apache#2671

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

After applying the patch, gradle build will success after running
pytest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaofengshi shaofengshi

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2671] fix(python-client): exclude pytest_cache from rat test shaofengshi/gravitino
1 participant
@shaofengshi