Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Shade graviton-client depends JAR #211

Closed
xunliu opened this issue Aug 10, 2023 · 2 comments · Fixed by #311
Closed

[Subtask] Shade graviton-client depends JAR #211

xunliu opened this issue Aug 10, 2023 · 2 comments · Fixed by #311
Assignees
@jerryshao
Milestone
Graviton v0.2.0

Comments

@xunliu
Copy link
Member

xunliu commented Aug 10, 2023

Describe the subtask

We need to import graviton-client JAR to 3rd system to use, to avoid JAR package conflicts, So we need to shade graviton-client all depends JAR into graviton-client-${version}.jar

Parent issue

#177
@xunliu xunliu mentioned this issue Aug 10, 2023
Closed
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Aug 11, 2023
@jerryshao jerryshao self-assigned this Aug 30, 2023
@jerryshao
Copy link
Contributor

I'm going to work on this if you're not working it @xunliu

@xunliu
Copy link
Member Author

xunliu commented Aug 31, 2023

OK, I didn't work on this issue. You can implement this. thanks!

@jerryshao jerryshao mentioned this issue Sep 1, 2023
Merged
xunliu pushed a commit that referenced this issue Sep 2, 2023
@jerryshao
[#211] package: Shade the client-java output and bump the version (#311)
c7777b9 
### What changes were proposed in this pull request?

This PR proposes to add shadowJar support for `client-java` module. It
will package an uber java with all dependencies shaded, user could
leverage this jar to avoid potential dependencies issues.

### Why are the changes needed?

`client-java` will be used by other projects, so we need to shaded all
the dependencies of `client-java` to avoid conflicts when outside users
leverage this package.

Fix: #211 

### Does this PR introduce _any_ user-facing change?

NA

### How was this patch tested?

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryshao jerryshao

Labels
None yet
Projects
None yet
Milestone
Graviton v0.2.0
Development

Successfully merging a pull request may close this issue.

[#211] package: Shade the client-java output and bump the version jerryshao/unified-catalog
2 participants
@jerryshao @xunliu