Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Impove test coverage in the core module #181

Closed
justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #187
Closed

[Improvement] Impove test coverage in the core module #181

justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #187
Assignees
@justinmclean
Labels
improvement Improvements on everything
Milestone
Graviton v0.1.0 (...

Comments

@justinmclean
Copy link
Member

justinmclean commented Aug 7, 2023 •
edited
Loading

What would you like to be improved?

Improve test coverage in the core module

How should we improve?

By adding tests
@justinmclean justinmclean added the improvement Improvements on everything label Aug 7, 2023
@justinmclean justinmclean self-assigned this Aug 7, 2023
@justinmclean justinmclean changed the title [Improvement] Impove test coverage in the code module [Improvement] Impove test coverage in the core module Aug 7, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Aug 7, 2023
@justinmclean justinmclean mentioned this issue Aug 8, 2023
Merged
jerryshao pushed a commit that referenced this issue Aug 8, 2023
@justinmclean
[#181] Improve core tests (#187)
51af61b 
### What changes were proposed in this pull request?

Added tests for some classes that were missing tests.

### Why are the changes needed?

To improve code coverage and document code.

Fix: #181

### Does this PR introduce _any_ user-facing change?

No code changes.

### How was this patch tested?

Build and test pass locally. Merged main as it contained changes that
would cause original tests to fail.

---------

Co-authored-by: Justin Mclean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.1.0 (updated)
Development

Successfully merging a pull request may close this issue.

[#181] Improve core tests justinmclean/gravitino_old
2 participants
@justinmclean @jerryshao