Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Impove test coverage in the server module #180

Closed
justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #182
Closed

[Improvement] Impove test coverage in the server module #180

justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #182
Assignees
@justinmclean
Labels
improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Increase test coverage in the server module.

How should we improve?

By adding more tests.
@justinmclean justinmclean added the improvement Improvements on everything label Aug 7, 2023
@justinmclean justinmclean self-assigned this Aug 7, 2023
@justinmclean justinmclean mentioned this issue Aug 7, 2023
Merged
jerryshao pushed a commit that referenced this issue Aug 7, 2023
@justinmclean
[#180] test(server): add server tests. (#182)
f3d3257 
### What changes were proposed in this pull request?

Add unit tests for the server module. Some of the tests for
GravitonServer and JettyServer are not the best as the classes are not
easily testable.

### Why are the changes needed?

To increase code coverage and understanding and to document how to use
some code.

Fix: #180

### Does this PR introduce _any_ user-facing change?

No code changes made.

### How was this patch tested?

Build test pass locally.

Co-authored-by: Justin Mclean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#180] Add server tests. justinmclean/gravitino_old
1 participant
@justinmclean