Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improve English and add JavaDocs in the core module #176

Closed
justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #210
Closed

[Improvement] Improve English and add JavaDocs in the core module #176

justinmclean opened this issue Aug 7, 2023 · 0 comments · Fixed by #210
Assignees
@justinmclean
Labels
improvement Improvements on everything
Milestone
Graviton v0.1.0 (...

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Improve English in command and add JavaDocs.

How should we improve?

As above.
@justinmclean justinmclean added the improvement Improvements on everything label Aug 7, 2023
@justinmclean justinmclean self-assigned this Aug 7, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Aug 7, 2023
@justinmclean justinmclean mentioned this issue Aug 10, 2023
Merged
jerryshao pushed a commit that referenced this issue Aug 11, 2023
@justinmclean @xunliu
[#176] update English and JavaDocs in core module (#210)
3053303 
### What changes were proposed in this pull request?

Update English and JavaDocs in core module

### Why are the changes needed?

To document code and help people understand code base.

Fix: #176

### Does this PR introduce _any_ user-facing change?

Some minor code changes.

### How was this patch tested?

Build and test pass locally.

Co-authored-by: xunliu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.1.0 (updated)
Development

Successfully merging a pull request may close this issue.

[#176] update English and JavaDocs in core module justinmclean/gravitino_old
2 participants
@justinmclean @jerryshao