Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improve test coverage #171

Closed
justinmclean opened this issue Aug 7, 2023 · 1 comment · Fixed by #172
Closed

[Improvement] Improve test coverage #171

justinmclean opened this issue Aug 7, 2023 · 1 comment · Fixed by #172
Labels
improvement Improvements on everything
Milestone
Graviton v0.1.0 (...

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Improve test coverage.

How should we improve?

Write more tests to improve test coverage. Tests also provide documentation on how to use the code, making the code base easier to understand.
@justinmclean justinmclean added the improvement Improvements on everything label Aug 7, 2023
@yuqi1129
Copy link
Contributor

yuqi1129 commented Aug 7, 2023

Great work

@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Aug 7, 2023
@yuqi1129 yuqi1129 mentioned this issue Aug 8, 2023
Merged
yuqi1129 pushed a commit that referenced this issue Aug 8, 2023
@justinmclean
[#171] Impove test coverage (#172)
c73160c 
### What changes were proposed in this pull request?

Added more tests.

### Why are the changes needed?

To increase code coverage and document how to use code to help users
understand how to use it.

Fix: #171

### Does this PR introduce _any_ user-facing change?

No code changes were made.

### How was this patch tested?

Build and test pass on local machine.

---------

Co-authored-by: Justin Mclean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements on everything
Projects
None yet
Milestone
Graviton v0.1.0 (updated)
Development

Successfully merging a pull request may close this issue.

[#171] Impove test coverage justinmclean/gravitino_old
3 participants
@justinmclean @jerryshao @yuqi1129