-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-2170] Define Gobblin-on-Temporal dynamic ScalingDirective
s with parser and FsScalingDirectiveSource
#4068
Open
phet
wants to merge
11
commits into
apache:master
Choose a base branch
from
phet:temporal-dynamic-scaling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4068 +/- ##
============================================
- Coverage 51.47% 50.51% -0.97%
+ Complexity 7546 5964 -1582
============================================
Files 1386 1079 -307
Lines 52105 41523 -10582
Branches 5727 4658 -1069
============================================
- Hits 26821 20975 -5846
+ Misses 22990 18760 -4230
+ Partials 2294 1788 -506 ☔ View full report in Codecov by Sentry. |
phet
force-pushed
the
temporal-dynamic-scaling
branch
from
October 30, 2024 06:36
0245540
to
f0b6e89
Compare
Blazer-007
reviewed
Nov 4, 2024
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/dynamic/ProfileDerivationTest.java
Show resolved
Hide resolved
phet
changed the title
[DRAFT] Define Gobblin-on-Temporal
[GOBBLIN-2170] Define Gobblin-on-Temporal dynamic Nov 5, 2024
WorkforcePlan
and dynamic ScalingDirective
s with parserScalingDirective
s with parser and FsScalingDirectiveSource
…ve`s with parser
phet
force-pushed
the
temporal-dynamic-scaling
branch
from
November 6, 2024 20:21
8929a8f
to
a31969e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Enable Gobblin-on-Temporal to dynamically scale up/down the number of workers and also to reconfigure worker containers (including resource resizing). Support a heterogeneous workforce of multiple simultaneous worker container configurations.
The
ScalingDirective
,WorkforcePlan
, andWorkforceStaffing
abstractions will allow implementing with the current GoT-atop-YARN deployment, while also being general enough for containerization beyond YARN, such as with k8s.The
ScalingDirectiveParser
supports a simple and compact human-readable syntax for Dynamic Scaling Directives that is "FS-safe", so each DSD may appear as a filename w/o excessive encoding. This enables theFsScalingDirectiveSource
to function as a source of Dynamic Scaling Directives by reading entries from a HDFS directory ordered by file modtime.Suggested review sequence:
ScalingDirective
=>WorkforceStaffing
=>WorkforcePlan
(withWorkforceStaffingTest
andWorkforcePlanTest
along the way)ScalingDirectiveParser
(withScalingDirectiveParserTest
)FsScalingDirectiveSource
(withFsScalingDirectiveSourceTest
)Tests
unit tests included
Commits