Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2159] Adding support for partition level copy in Iceberg distcp #4058

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Blazer-007
Copy link
Contributor

@Blazer-007 Blazer-007 commented Sep 22, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • [✅] Here are some details about my PR, including screenshots (if applicable):
    • Currently, in Iceberg Distcp it is not possible to specify which partitions to copy. This PR aims to do that by adding support for partition level copy in Iceberg distcp.
    • It supports partition copy between two different iceberg tables meaning with different UUIDs.

Tests

  • [✅] My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • IcebergPartitionDatasetTest
    • IcebergReplacePartitionsStepTest
    • IcebergTableTest [ Updated ]
      - testGetPartitionSpecificDataFiles()
      - testReplacePartitions()
    • IcebergDateTimePartitionFilterPredicateTest
    • IcebergPartitionFilterPredicateFactoryTest
    • IcebergPartitionFilterPredicateTest
    • IcebergPartitionFilterPredicateUtilTest

Commits

  • [✅] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant