-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35401][Connectors/Sqs] Add Sqs Table API connector #155
base: main
Are you sure you want to change the base?
Conversation
@hlteoh37 could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @vahmed-hamdy !
|
||
/** Options for the SQS connector. */ | ||
@PublicEvolving | ||
public class SqsConnectorOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this with SqsConfigConstants
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We havent' released the connector, so let's make this uniform before we release it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can do but do we want to break the consistency with other AWS Table API connectors?
They are not merged for any of kinesis, firehose or DDB. I think it might be confusing for users since they are Public classes.
...s/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/table/SqsDynamicSink.java
Show resolved
Hide resolved
5400e44
to
90f6c8d
Compare
@hlteoh37 Thanks for the review, Addressed now! |
90f6c8d
to
69f4137
Compare
@hlteoh37 gentle reminder if you have any other feedback |
Purpose of the change
Implements the Table API for the Sqs Sink Connector.
Verifying this change
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving)
)