[FLINK-34865][pipeline-connector]support sync table and column comments #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
|
resolve some problems from PR #3039, thanks for @lvyanquan and @dufeng1010 and @yuxiqian |
|
@yuxiqian Would you like to help review this PR? |
|
Sure, I'll take it. |
yuxiqian
reviewed
Aug 8, 2024
...tor-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisDataSinkOptions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Seems this PR also enables Doris connector to apply comments from upstream. Could you please also add an comment sync E2e case in MySql2DorisE2eITCase?
add docs for `charset-encoding` param
|
fix paimon |
@melin thanks |
…link-cdc-connectors into enable-inculde-comments
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don‘t support sync comments of table or column, so the pipeline sink cannot obtain them. Users must get the comments from the source, it's a bad experience.