-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34865][pipeline-connector]support sync table and column comments #3482
base: master
Are you sure you want to change the base?
Conversation
resolve some problems from PR #3039, thanks for @lvyanquan and @dufeng1010 and @yuxiqian |
@yuxiqian Would you like to help review this PR? |
Sure, I'll take it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @qg-lin's contribution. I also wonder should we support sending changed table / column comments to downstream as SchemaChangeEvents?
...tor-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisDataSinkOptions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this PR also enables Doris connector to apply comments from upstream. Could you please also add an comment sync E2e case in MySql2DorisE2eITCase
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My pleasure
add docs for `charset-encoding` param
@melin thanks |
…link-cdc-connectors into enable-inculde-comments
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
Currently we don‘t support sync comments of table or column, so the pipeline sink cannot obtain them. Users must get the comments from the source, it's a bad experience.