-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdc-connector][postgres]Flink cdc pipeline support postgres source #3442
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comment:
|
||
@Override | ||
protected boolean isSchemaChangeRecord(SourceRecord record) { | ||
Schema keySchema = record.keySchema(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does postgres have schema change record?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code has been modified
|
||
private void sendCreateTableEvent( | ||
PostgresConnection jdbc, TableId tableId, SourceOutput<Event> output) { | ||
Schema schema = PostgresSchemaUtils.getTableSchema(tableId, sourceConfig, jdbc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if log's schema is different with current table schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for reviewing the code for me |
Is there anyone who can help review this? |
Is there anyone who can help review this, pls? |
Flink cdc pipeline support postgres source